Fix button template/triggers #1296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
controls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button's current Template is not compatible with its triggers.
<Trigger Property="IsEnabled" Value="False">affectsTargetName="ContentBorder"but now the BorderThickness and other properties located in a nested Border. And with this template all state triggers do nothingThis PR fixes this behavior and now the triggers work as they should work. I removed the redundant nested Border and moved all properties to the ContentBorder
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Triggers do not change the element border in any way, but must
Issue Number: N/A
What is the new behavior?
The triggers are working
